sbcl: fix check phase for darwin 24.05 only #361072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See NixOS#359214 and in particular @szlend’s comment. Thanks to @pcboy for reporting.
ofborg
bot
added
11.by: package-maintainer
szlend
approved these changes
Dec 3, 2024
|
no it's fine to include somewhere directly I just don't know what the proper target branch is. What's the 24.05 equivalent of Although I am surprised at the low rebuild count... maybe because it fixes a previously broken package? On master, changing sbcl causes an avalanche of >1k lisp package rebuilds. |
wegank
added
the
12.approvals: 1
|
Maybe we only recurse sbclPackages on Linux? Rebuild count does not know about failed builds anyway (it's an evaluation check). |
|
Release branch of 24.05 is release-24.05 |
|
thanks @7c6f434c , base changed |
szlend
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
See #359214 and in particular @szlend’s comment. Thanks to @pcboy for reporting.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.